linux-kernel - Re: [PATCH net] lib: test_objagg: Set error message in check_expect_hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGPSFlt0ZXN3bJ45@shredder>
Date: Tue, 1 Jul 2025 15:18:30 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jiri Pirko <jiri@...nulli.us>, Arnd Bergmann <arnd@...db.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ido Schimmel <idosch@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] lib: test_objagg: Set error message in
 check_expect_hints_stats()

On Mon, Jun 30, 2025 at 02:36:40PM -0500, Dan Carpenter wrote:
> Smatch complains that the error message isn't set in the caller:
> 
>     lib/test_objagg.c:923 test_hints_case2()
>     error: uninitialized symbol 'errmsg'.
> 
> This static checker warning only showed up after a recent refactoring
> but the bug dates back to when the code was originally added.  This
> likely doesn't affect anything in real life.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202506281403.DsuyHFTZ-lkp@intel.com/
> Fixes: 0a020d416d0a ("lib: introduce initial implementation of object aggregation manager")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>