linux-kernel - Re: [PATCH v2] staging: greybus: gbphy: fix up const issue with the match callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGPSfRSTDXsNNp1P@hovoldconsulting.com>
Date: Tue, 1 Jul 2025 14:20:13 +0200
From: Johan Hovold <johan@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, Alex Elder <elder@...nel.org>,
	greybus-dev@...ts.linaro.org
Subject: Re: [PATCH v2] staging: greybus: gbphy: fix up const issue with the
 match callback

On Tue, Jul 01, 2025 at 01:06:16PM +0200, Greg Kroah-Hartman wrote:
> gbphy_dev_match_id() should be taking a const pointer, as the pointer
> passed to it from the container_of() call was const to start with (it
> was accidentally cast away with the call.)  Fix this all up by correctly
> marking the pointer types.
> 
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: greybus-dev@...ts.linaro.org
> Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> v2: - add Fixes: line as pointed out by Johan
>     - don't make gbphy_dev const, it's not needed, as pointed out by
>       Johan

Reviewed-by: Johan Hovold <johan@...nel.org>