linux-kernel - Re: [PATCH net-next v06 2/8] hinic3: Complete Event Queue interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f16bb726-e8ba-4b9f-9657-5860b4f118bf@redhat.com>
Date: Tue, 1 Jul 2025 14:42:16 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, linux-doc@...r.kernel.org,
 Jonathan Corbet <corbet@....net>, Bjorn Helgaas <helgaas@...nel.org>,
 luosifu <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>,
 Shen Chenyang <shenchenyang1@...ilicon.com>,
 Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
 Shi Jing <shijing34@...wei.com>, Meny Yossefi <meny.yossefi@...wei.com>,
 Gur Stavi <gur.stavi@...wei.com>, Lee Trager <lee@...ger.us>,
 Michael Ellerman <mpe@...erman.id.au>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Suman Ghosh
 <sumang@...vell.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Joe Damato <jdamato@...tly.com>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next v06 2/8] hinic3: Complete Event Queue interfaces

On 6/27/25 8:12 AM, Fan Gong wrote:
>  static void reschedule_eq_handler(struct hinic3_eq *eq)
>  {
> -	struct hinic3_aeqs *aeqs = aeq_to_aeqs(eq);
> +	if (eq->type == HINIC3_AEQ) {
> +		struct hinic3_aeqs *aeqs = aeq_to_aeqs(eq);
>  
> -	queue_work_on(WORK_CPU_UNBOUND, aeqs->workq, &eq->aeq_work);
> +		queue_work_on(WORK_CPU_UNBOUND, aeqs->workq, &eq->aeq_work);
> +	} else {
> +		tasklet_schedule(&eq->ceq_tasklet);

I'm sorry for the late feedback, but tasklets API are deprecated, the
suggested alternative is threaded IRQ.

/P