linux-kernel - Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGUgxCzTmcBHbdR5@alpha.franken.de>
Date: Wed, 2 Jul 2025 14:06:28 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Shiji Yang <yangshiji66@...look.com>
Cc: linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-spi@...r.kernel.org, John Crispin <john@...ozen.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as
 static

On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> These functions are only used in the current source file "vpe-mt.c".
> Do not export them and mark them as static to silence the missing
> prototypes warnings:

you are breaking the whole idea of this interface, The functions are
exported for other kernel modules. By removing it you break them.

If we know that this interface is unsued, we should remove the
whole kernel module, but I don't know if it used somewhere.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]