linux-kernel - Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSBPR01MB1670E0E820F98E006B805C69BC43A@OSBPR01MB1670.jpnprd01.prod.outlook.com>
Date: Thu,  3 Jul 2025 21:25:24 +0800
From: Shiji Yang <yangshiji66@...look.com>
To: tsbogend@...ha.franken.de
Cc: broonie@...nel.org,
	john@...ozen.org,
	linus.walleij@...aro.org,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-mips@...r.kernel.org,
	linux-spi@...r.kernel.org,
	Shiji Yang <yangshiji66@...look.com>
Subject: Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static

On  Wed, 2 Jul 2025 14:06:28 +0200, Thomas Bogendoerfer wrote:

> On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> > These functions are only used in the current source file "vpe-mt.c".
> > Do not export them and mark them as static to silence the missing
> > prototypes warnings:
> 
> you are breaking the whole idea of this interface, The functions are
> exported for other kernel modules. By removing it you break them.
> 
> If we know that this interface is unsued, we should remove the
> whole kernel module, but I don't know if it used somewhere.
> 
> Thomas.

Thank you for your review. It seems that MIPS/Lantiq platform still
rely on the vpe-mt module. I've sent another patch to fix these
vpe-mt compilation warnings. Suppress patches 12 and 13:

https://lore.kernel.org/linux-mips/OSBPR01MB16706BF0ABF807E870C79A86BC43A@OSBPR01MB1670.jpnprd01.prod.outlook.com/

Regards,
Shiji Yang