linux-kernel - Re: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175146290821.1131432.4001907939183416459.robh@kernel.org>
Date: Wed, 02 Jul 2025 08:28:31 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, linux-kernel@...r.kernel.org, 
 bsp-development.geo@...ca-geosystems.com, lee@...nel.org, 
 devicetree@...r.kernel.org, pavel@...nel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios
 property


On Wed, 02 Jul 2025 19:47:58 +0800, LI Qingwu wrote:
> Some PWM LED chips have a dedicated enable GPIO.
> This commit adds the support to specify such GPIO.
> 
> Signed-off-by: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
> ---
>  Documentation/devicetree/bindings/leds/leds-pwm.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/leds/leds-pwm.yaml:44:21: [error] empty value in block mapping (empty-values)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-pwm.yaml: ignoring, error in schema: patternProperties: ^led(-[0-9a-f]+)?$: properties: enable-gpios: description
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-pwm.yaml: patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios:description: None is not of type 'string'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-pwm.yaml: patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios: 'anyOf' conditional failed, one must be fixed:
	'enable-gpios' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
	'type' was expected
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-pwm.yaml: patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios: 'anyOf' conditional failed, one must be fixed:
	'enable-gpios' is not one of ['maxItems', 'description', 'deprecated']
		hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
	Additional properties are not allowed ('enable-gpios' was unexpected)
		hint: Arrays must be described with a combination of minItems/maxItems/items
	'enable-gpios' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
	'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
	1 is less than the minimum of 2
		hint: Arrays must be described with a combination of minItems/maxItems/items
	hint: cell array properties must define how many entries and what the entries are when there is more than one entry.
	from schema $id: http://devicetree.org/meta-schemas/gpios.yaml#
Documentation/devicetree/bindings/leds/leds-pwm.example.dtb: /example-0/led-controller: failed to match any schema with compatible: ['pwm-leds']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250702114759.223925-1-Qing-wu.Li@leica-geosystems.com.cn

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.