linux-kernel - RE: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <AM9PR06MB79557F8FFA113011C4D824D6D743A@AM9PR06MB7955.eurprd06.prod.outlook.com>
Date: Thu, 3 Jul 2025 03:54:47 +0000
From: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, GEO-CHHER-bsp-development
	<bsp-development.geo@...ca-geosystems.com>, "lee@...nel.org"
	<lee@...nel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"pavel@...nel.org" <pavel@...nel.org>, "linux-leds@...r.kernel.org"
	<linux-leds@...r.kernel.org>
Subject: RE: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property



> -----Original Message-----
> From: Rob Herring (Arm) <robh@...nel.org>
> Sent: Wednesday, July 2, 2025 9:29 PM
> To: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
> Cc: krzk+dt@...nel.org; conor+dt@...nel.org; linux-kernel@...r.kernel.org;
> GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>;
> lee@...nel.org; devicetree@...r.kernel.org; pavel@...nel.org;
> linux-leds@...r.kernel.org
> Subject: Re: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property
> 
> [You don't often get email from robh@...nel.org. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> This email is not from Hexagon's Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On Wed, 02 Jul 2025 19:47:58 +0800, LI Qingwu wrote:
> > Some PWM LED chips have a dedicated enable GPIO.
> > This commit adds the support to specify such GPIO.
> >
> > Signed-off-by: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-pwm.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/leds/leds-pwm.yaml:44:21: [error] empty
> value in block mapping (empty-values)

Fixed in V3

> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/l
> eds-pwm.yaml: ignoring, error in schema: patternProperties: ^led(-[0-9a-f]+)?$:
> properties: enable-gpios: description
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/l
> eds-pwm.yaml:
> patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios:description: None
> is not of type 'string'
>         from schema $id:
> https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fjson-sche
> ma.org%2Fdraft-07%2Fschema%23&data=05%7C02%7CQing-wu.Li%40leica-ge
> osystems.com.cn%7Caaeff71db4f841ea959f08ddb96c586e%7C1b16ab3eb8f64f
> e39f3e2db7fe549f6a%7C0%7C0%7C638870597187709015%7CUnknown%7CT
> WFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=SMmSnn%
> 2BwemnBgU6prZWfMiZ3nMXk20PKDFB96E5vMoI%3D&reserved=0
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/l
> eds-pwm.yaml: patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios:
> 'anyOf' conditional failed, one must be fixed:
>         'enable-gpios' is not one of ['$ref', 'additionalItems',
> 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies',
> 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else',
> 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems',
> 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern',
> 'patternProperties', 'properties', 'required', 'then', 'typeSize',
> 'unevaluatedProperties', 'uniqueItems']
>         'type' was expected
>         from schema $id:
> https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fmeta-schemas%2Fkeywords.yaml%23&data=05%7C02%7CQing-wu.Li
> %40leica-geosystems.com.cn%7Caaeff71db4f841ea959f08ddb96c586e%7C1b1
> 6ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C638870597187750588%7CUnk
> nown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsI
> lAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=
> B4E7joIeKPsOCw1Vb0dr4O4WAZJi5OuPjFMdGyIH%2BqY%3D&reserved=0
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/l
> eds-pwm.yaml: patternProperties:^led(-[0-9a-f]+)?$:properties:enable-gpios:
> 'anyOf' conditional failed, one must be fixed:
>         'enable-gpios' is not one of ['maxItems', 'description', 'deprecated']
>                 hint: Only "maxItems" is required for a single entry if there
> are no constraints defined for the values.
>         Additional properties are not allowed ('enable-gpios' was unexpected)
>                 hint: Arrays must be described with a combination of
> minItems/maxItems/items
>         'enable-gpios' is not one of ['description', 'deprecated', 'const', 'enum',
> 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
>         'maxItems' is not one of ['description', 'deprecated', 'const', 'enum',
> 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
>         1 is less than the minimum of 2
>                 hint: Arrays must be described with a combination of
> minItems/maxItems/items
>         hint: cell array properties must define how many entries and what the
> entries are when there is more than one entry.
>         from schema $id:
> https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fmeta-schemas%2Fgpios.yaml%23&data=05%7C02%7CQing-wu.Li%40l
> eica-geosystems.com.cn%7Caaeff71db4f841ea959f08ddb96c586e%7C1b16ab3
> eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C638870597187780819%7CUnknown
> %7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJ
> XaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=R9Ixi
> 0hiwK1YgNx1uHbGLDza2Id%2Fmfuw62TiQ6A2QVY%3D&reserved=0
> Documentation/devicetree/bindings/leds/leds-pwm.example.dtb:
> /example-0/led-controller: failed to match any schema with compatible:
> ['pwm-leds']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor
> k.ozlabs.org%2Fproject%2Fdevicetree-bindings%2Fpatch%2F20250702114759.
> 223925-1-Qing-wu.Li%40leica-geosystems.com.cn&data=05%7C02%7CQing-wu
> .Li%40leica-geosystems.com.cn%7Caaeff71db4f841ea959f08ddb96c586e%7C1b
> 16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C638870597187806331%7CUn
> known%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCI
> sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> a=n%2BgfWLuIv%2FVPSodnF7rj7LqwTaMtOIbiAztOasgfDlQ%3D&reserved=0
> 
> The base for the series is generally the latest rc1. A different dependency should
> be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.