linux-kernel - Re: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507021011.sDAHGinj-lkp@intel.com>
Date: Wed, 2 Jul 2025 11:04:28 +0800
From: kernel test robot <lkp@...el.com>
To: Binbin Zhou <zhoubinbin@...ngson.cn>,
	Binbin Zhou <zhoubb.aaron@...il.com>,
	Huacai Chen <chenhuacai@...ngson.cn>, Lee Jones <lee@...nel.org>,
	Corey Minyard <minyard@....org>
Cc: oe-kbuild-all@...ts.linux.dev, Xuerui Wang <kernel@...0n.name>,
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net, jeffbai@...c.io,
	kexybiscuit@...c.io, wangyao@...ote.com,
	Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function
 support

Hi Binbin,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3d77b3cc7cc8115d89fa14eaf601e56372953484]

url:    https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mfd-ls2kbmc-Introduce-Loongson-2K-BMC-core-driver/20250626-203353
base:   3d77b3cc7cc8115d89fa14eaf601e56372953484
patch link:    https://lore.kernel.org/r/78b06d1c7ae0677868e0c7498b589af163313c8d.1750939357.git.zhoubinbin%40loongson.cn
patch subject: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20250702/202507021011.sDAHGinj-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250702/202507021011.sDAHGinj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507021011.sDAHGinj-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/mfd/ls2k-bmc-core.c: In function 'ls2k_bmc_pdata_initial':
>> drivers/mfd/ls2k-bmc-core.c:349:15: error: implicit declaration of function 'acpi_register_gsi' [-Wimplicit-function-declaration]
     349 |         irq = acpi_register_gsi(NULL, gsi, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW);
         |               ^~~~~~~~~~~~~~~~~
>> drivers/mfd/ls2k-bmc-core.c:376:9: error: implicit declaration of function 'acpi_unregister_gsi'; did you mean 'arch_unregister_cpu'? [-Wimplicit-function-declaration]
     376 |         acpi_unregister_gsi(gsi);
         |         ^~~~~~~~~~~~~~~~~~~
         |         arch_unregister_cpu


vim +/acpi_register_gsi +349 drivers/mfd/ls2k-bmc-core.c

   326	
   327	static int ls2k_bmc_pdata_initial(struct pci_dev *pdev, struct ls2k_bmc_pdata *priv)
   328	{
   329		int gsi = 16 + (LS2K_BMC_RESET_GPIO & 7);
   330		void __iomem *gpio_base;
   331		int irq, ret;
   332	
   333		ls2k_bmc_save_pci_data(pdev, priv);
   334	
   335		INIT_WORK(&priv->bmc_reset_work, ls2k_bmc_events_fn);
   336	
   337		ret = devm_request_irq(&pdev->dev, pdev->irq, ls2k_bmc_interrupt,
   338				       IRQF_SHARED | IRQF_TRIGGER_FALLING, "ls2kbmc pcie", priv);
   339		if (ret) {
   340			dev_err(priv->dev, "LS2KBMC PCI-E request_irq(%d) failed\n", pdev->irq);
   341			return ret;
   342		}
   343	
   344		/*
   345		 * Since gpio_chip->to_irq is not implemented in the Loongson-3 GPIO driver,
   346		 * acpi_register_gsi() is used to obtain the GPIO irq. The GPIO interrupt is a
   347		 * watchdog interrupt that is triggered when the BMC resets.
   348		 */
 > 349		irq = acpi_register_gsi(NULL, gsi, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW);
   350		if (irq < 0)
   351			return irq;
   352	
   353		gpio_base = ioremap(LOONGSON_GPIO_REG_BASE, LOONGSON_GPIO_REG_SIZE);
   354		if (!gpio_base) {
   355			ret = PTR_ERR(gpio_base);
   356			goto acpi_failed;
   357		}
   358	
   359		writel(readl(gpio_base + LOONGSON_GPIO_OEN) | BIT(LS2K_BMC_RESET_GPIO),
   360		       gpio_base + LOONGSON_GPIO_OEN);
   361		writel(readl(gpio_base + LOONGSON_GPIO_FUNC) & ~BIT(LS2K_BMC_RESET_GPIO),
   362		       gpio_base + LOONGSON_GPIO_FUNC);
   363		writel(readl(gpio_base + LOONGSON_GPIO_INTPOL) & ~BIT(LS2K_BMC_RESET_GPIO),
   364		       gpio_base + LOONGSON_GPIO_INTPOL);
   365		writel(readl(gpio_base + LOONGSON_GPIO_INTEN) | BIT(LS2K_BMC_RESET_GPIO),
   366		       gpio_base + LOONGSON_GPIO_INTEN);
   367	
   368		ret = devm_request_irq(priv->dev, irq, ls2k_bmc_interrupt,
   369				       IRQF_SHARED | IRQF_TRIGGER_FALLING, "ls2kbmc gpio", priv);
   370		if (ret)
   371			dev_err(priv->dev, "LS2KBMC GPIO request_irq(%d) failed\n", irq);
   372	
   373		iounmap(gpio_base);
   374	
   375	acpi_failed:
 > 376		acpi_unregister_gsi(gsi);
   377		return ret;
   378	}
   379	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki