linux-kernel - Re: [PATCH 1/5] pinctrl: sunxi: v3s: Fix wrong comment about UART2 pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04ee563fda1411961e6f16bb1a2ab0a3163d550d.camel@icenowy.me>
Date: Wed, 02 Jul 2025 11:04:18 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Paul Kocialkowski <paulk@...-base.io>, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-gpio@...r.kernel.org
Cc: Yong Deng <yong.deng@...ewell.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec
 <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Maxime Ripard <mripard@...nel.org>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann
 <tzimmermann@...e.de>,  David Airlie <airlied@...il.com>, Simona Vetter
 <simona@...ll.ch>, Linus Walleij <linus.walleij@...aro.org>,  Icenowy Zheng
 <icenowy@...c.xyz>, Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH 1/5] pinctrl: sunxi: v3s: Fix wrong comment about UART2
 pinmux

在 2025-07-01星期二的 22:11 +0200，Paul Kocialkowski写道：
> The original comment doesn't match the pin attribution, probably due
> to a hasty copy/paste.
> 
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>
> ---
>  drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
> b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
> index 696d7dd8d87b..2e3bd36a4410 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
> @@ -45,7 +45,7 @@ static const struct sunxi_desc_pin sun8i_v3s_pins[]
> = {
>         SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 3),
>                   SUNXI_FUNCTION(0x0, "gpio_in"),
>                   SUNXI_FUNCTION(0x1, "gpio_out"),
> -                 SUNXI_FUNCTION(0x2, "uart2"),         /* D1 */
> +                 SUNXI_FUNCTION(0x2, "uart2"),         /* CTS */

LGTM. Blame to my ADHD ;-)

Reviewed-by: Icenowy Zheng <uwu@...nowy.me>

>                   SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 3)),  /* PB_EINT3
> */
>         SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 4),
>                   SUNXI_FUNCTION(0x0, "gpio_in"),