linux-kernel - Re: [PATCH 2/4] io_uring/cmd: introduce IORING_URING_CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d93770-886f-4337-a922-579e102c0067@gnuweeb.org>
Date: Wed, 2 Jul 2025 13:44:04 +0700
From: Ammar Faizi <ammarfaizi2@...weeb.org>
To: Daniel Vacek <neelx@...e.com>
Cc: Jens Axboe <axboe@...nel.dk>,
 Caleb Sander Mateos <csander@...estorage.com>, Chris Mason <clm@...com>,
 Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
 Mark Harmstone <maharmstone@...com>,
 Linux Btrfs Mailing List <linux-btrfs@...r.kernel.org>,
 io-uring Mailing List <io-uring@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] io_uring/cmd: introduce IORING_URING_CMD_REISSUE flag

On 7/2/25 1:27 PM, Daniel Vacek wrote:
> On Tue, 1 Jul 2025 at 21:04, Jens Axboe <axboe@...nel.dk> wrote:
>> Probably fold that under the next statement?
>>
>>          if (ret == -EAGAIN || ret == -EIOCBQUEUED) {
>>                  if (ret == -EAGAIN) {
>>                          ioucmd->flags |= IORING_URING_CMD_REISSUE;
>>                  return ret;
>>          }
>>
>> ?
> 
> I'd argue the original looks simpler, cleaner.

I propose doing it this way:

	if (ret == -EAGAIN) {
		ioucmd->flags |= IORING_URING_CMD_REISSUE;
		return ret;
	}

	if (ret == -EIOCBQUEUED)
		return ret;

It's simpler because the -EAGAIN is only checked once :)

-- 
Ammar Faizi