linux-kernel - Re: [PATCH 2/4] io_uring/cmd: introduce IORING_URING_CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <07162148-1F57-4198-BC82-08501232C2A9@gmail.com>
Date: Wed, 2 Jul 2025 15:00:07 +0800
From: Alan Huang <mmpgouride@...il.com>
To: Ammar Faizi <ammarfaizi2@...weeb.org>
Cc: Daniel Vacek <neelx@...e.com>,
 Jens Axboe <axboe@...nel.dk>,
 Caleb Sander Mateos <csander@...estorage.com>,
 Chris Mason <clm@...com>,
 Josef Bacik <josef@...icpanda.com>,
 David Sterba <dsterba@...e.com>,
 Mark Harmstone <maharmstone@...com>,
 Linux Btrfs Mailing List <linux-btrfs@...r.kernel.org>,
 io-uring Mailing List <io-uring@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] io_uring/cmd: introduce IORING_URING_CMD_REISSUE flag

On Jul 2, 2025, at 14:44, Ammar Faizi <ammarfaizi2@...weeb.org> wrote:
> 
> On 7/2/25 1:27 PM, Daniel Vacek wrote:
>> On Tue, 1 Jul 2025 at 21:04, Jens Axboe <axboe@...nel.dk> wrote:
>>> Probably fold that under the next statement?
>>> 
>>>         if (ret == -EAGAIN || ret == -EIOCBQUEUED) {
>>>                 if (ret == -EAGAIN) {
>>>                         ioucmd->flags |= IORING_URING_CMD_REISSUE;
>>>                 return ret;
>>>         }
>>> 
>>> ?
>> I'd argue the original looks simpler, cleaner.
> 
> I propose doing it this way:
> 
> if (ret == -EAGAIN) {
> ioucmd->flags |= IORING_URING_CMD_REISSUE;
> return ret;
> }
> 
> if (ret == -EIOCBQUEUED)
> return ret;
> 
> It's simpler because the -EAGAIN is only checked once :)


Agreed


> 
> -- 
> Ammar Faizi
>