linux-kernel - Re: [PATCH net-next v12 04/14] dpll: zl3073x: Add support for devlink device info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6050475d-0387-4eb0-8a72-15e81a14e6cf@redhat.com>
Date: Wed, 2 Jul 2025 13:52:54 +0200
From: Ivan Vecera <ivecera@...hat.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 Jason Gunthorpe <jgg@...pe.ca>, Shannon Nelson <shannon.nelson@....com>,
 Dave Jiang <dave.jiang@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 Michal Schmidt <mschmidt@...hat.com>, Petr Oros <poros@...hat.com>
Subject: Re: [PATCH net-next v12 04/14] dpll: zl3073x: Add support for devlink
 device info

On 02. 07. 25 1:41 odp., Jiri Pirko wrote:
> Wed, Jul 02, 2025 at 01:38:03PM +0200, ivecera@...hat.com wrote:
>> On 02. 07. 25 12:25 odp., Jiri Pirko wrote:
>>> Sun, Jun 29, 2025 at 09:10:39PM +0200, ivecera@...hat.com wrote:
>>>
>>> [...]
>>>
>>>> +	snprintf(buf, sizeof(buf), "%lu.%lu.%lu.%lu",
>>>> +		 FIELD_GET(GENMASK(31, 24), cfg_ver),
>>>> +		 FIELD_GET(GENMASK(23, 16), cfg_ver),
>>>> +		 FIELD_GET(GENMASK(15, 8), cfg_ver),
>>>> +		 FIELD_GET(GENMASK(7, 0), cfg_ver));
>>>> +
>>>> +	return devlink_info_version_running_put(req, "cfg.custom_ver", buf);
>>>
>>> Nit:
>>>
>>> It's redundant to put "ver" string into version name. Also, isn't it
>>> rather "custom_config" or "custom_cfg"?
>>
>> As per datasheet, this is configuration custom version.
> 
> This is UAPI, we define it and we should make sure it make sense.
> Datasheet is sort of irrelevant.

OK, 'custom_cfg' make sense.

Will update.

I.