linux-kernel - Re: [PATCH 1/2] x86/tdx: Eliminate duplicate code in tdx_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09770a46-3d66-4256-a4b1-39d468daca65@intel.com>
Date: Thu, 3 Jul 2025 17:39:20 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Dave Hansen <dave.hansen@...el.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, <pbonzini@...hat.com>, <seanjc@...gle.com>,
	<vannapurve@...gle.com>
CC: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, "Thomas
 Gleixner" <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	<x86@...nel.org>, H Peter Anvin <hpa@...or.com>,
	<linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
	<rick.p.edgecombe@...el.com>, <kirill.shutemov@...ux.intel.com>,
	<kai.huang@...el.com>, <reinette.chatre@...el.com>, <xiaoyao.li@...el.com>,
	<tony.lindgren@...ux.intel.com>, <binbin.wu@...ux.intel.com>,
	<isaku.yamahata@...el.com>, <yan.y.zhao@...el.com>, <chao.gao@...el.com>
Subject: Re: [PATCH 1/2] x86/tdx: Eliminate duplicate code in tdx_clear_page()

On 03/07/2025 17:14, Dave Hansen wrote:
> On 7/3/25 04:40, Adrian Hunter wrote:
>> tdx_clear_page() and reset_tdx_pages() duplicate the TDX page clearing
>> logic.  Keep the tdx_clear_page() prototype but call reset_tdx_pages() for
>> the implementation.
> 
> Why keep the old prototype?

What prototype would you prefer?