linux-kernel - Re: [PATCH v7 0/8] iio: accel: adxl313: add power-save on activity/inactivity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGaWdEto-z3_dKr9@smile.fi.intel.com>
Date: Thu, 3 Jul 2025 17:40:52 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, corbet@....net, lucas.p.stankus@...il.com,
	lars@...afoo.de, Michael.Hennerich@...log.com, bagasdotme@...il.com,
	linux-iio@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/8] iio: accel: adxl313: add power-save on
 activity/inactivity

On Wed, Jul 02, 2025 at 11:08:11PM +0000, Lothar Rubusch wrote:
> The patch set covers the following topics:
> - add debug register and regmap cache
> - prepare iio channel scan_type and scan_index
> - prepare interrupt handling
> - implement fifo with watermark
> - add activity/inactivity together with auto-sleep with link bit
> - add ac coupled activity/inactivity, integrate with auto-sleep and link bit
> - documentation
> 
> Sorry for the fuzz: when I was about to rebase for submitting I
> noticed Jonathan actually already applied parts of this. I'd recommend
> to consider v6 rather over v5.
> 
> Since activity and inactivity here are implemented covering all axis, I
> assumed x&y&z and x|y|z, respectively. Thus the driver uses a fake
> channel for activity/inactiviy. AC-coupling is similar to other Analog Device
> accelerometers, so MAG_ADAPTIVE events are chosen. Combinations are
> documented and functionality tested and verified working.

Overall LGTM, one nit-pick somewhere, otherwise feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
to the rest of the series (which has no my tag yet).

-- 
With Best Regards,
Andy Shevchenko