linux-kernel - Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f4b72bb-3c5f-4137-a4f9-5ce94631d3c1@baylibre.com>
Date: Thu, 3 Jul 2025 16:26:58 -0500
From: David Lechner <dlechner@...libre.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3

On 7/1/25 5:30 PM, Rodrigo Gobbi wrote:
> The compatible grmn,lidar-lite-v3 is managed by the same
> driver of pulsedlight,lidar-lite-v2, which is a trivial device.

As a general rule of thumb, using the driver as justification for
dt-bindings is never a good reason. The bindings describe the hardware,
not the driver.

Assuming I found the correct datasheet [1], I see a power enable pin
and a mode control pin, so I would say that this isn't a trivial device.
Therefore this will need it's own new file. We could at least add
power-gpios and power-supply properties. How to handle the mode pin
isn't so clear to me though, so might omit that for now.

[1]: https://static.garmin.com/pumac/LIDAR_Lite_v3_Operation_Manual_and_Technical_Specifications.pdf

> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> Fixes: b257c1a45e99 ("iio: pulsedlight-lidar-lite-v2: add lidar-lite-v3 property")
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8da408107e55..cd9d7d5eec51 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -107,6 +107,8 @@ properties:
>            - fsl,mpl3115
>              # MPR121: Proximity Capacitive Touch Sensor Controller
>            - fsl,mpr121
> +            # Optical Distance Measurement Sensor
> +          - grmn,lidar-lite-v3
>              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
>            - honeywell,hi6130
>              # IBM Common Form Factor Power Supply Versions (all versions)