linux-kernel - Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <367e2429-bfd5-4c09-9d7a-194a0539091a@kernel.org>
Date: Fri, 4 Jul 2025 09:59:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3

On 02/07/2025 00:30, Rodrigo Gobbi wrote:
> The compatible grmn,lidar-lite-v3 is managed by the same
> driver of pulsedlight,lidar-lite-v2, which is a trivial device.

Nothing here explain the bug you are fixing. You need to be specific,
what is missing, what are you doing. Apparently you are documenting
existing ABI, but nothing in commit msg told me that.

As David pointed out, this is not a trivial device.

> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> Fixes: b257c1a45e99 ("iio: pulsedlight-lidar-lite-v2: add lidar-lite-v3 property")

SoB goes the last.


Best regards,
Krzysztof