linux-kernel - RE: [PATCH] vfio/pds: Fix missing detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52760B42D0EBCC5CBC04FB068C43A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Thu, 3 Jul 2025 06:44:45 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Brett Creeley <brett.creeley@....com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] vfio/pds: Fix missing detach_ioas op

> From: Brett Creeley <brett.creeley@....com>
> Sent: Thursday, July 3, 2025 12:38 AM
> 
> When CONFIG_IOMMUFD is enabled and a device is bound to the
> pds_vfio_pci
> driver, the following WARN_ON() trace is seen and probe fails:
> 
> WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317
> __vfio_register_dev+0x130/0x140 [vfio]
> <...>
> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -
> 22
> 
> This is because the driver's vfio_device_ops.detach_ioas isn't set.
> 
> Fix this by using the generic vfio_iommufd_physical_detach_ioas
> function.
> 
> Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
> Signed-off-by: Brett Creeley <brett.creeley@....com>

It's a surprise to see it caught so late...

Reviewed-by: Kevin Tian <kevin.tian@...el.com>