linux-kernel - Re: [PATCH] vfio/pds: Fix missing detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250711165104.37fec2f6.alex.williamson@redhat.com>
Date: Fri, 11 Jul 2025 16:51:04 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: Brett Creeley <brett.creeley@....com>
Cc: <jgg@...pe.ca>, <yishaih@...dia.com>,
 <shameerali.kolothum.thodi@...wei.com>, <kevin.tian@...el.com>,
 <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vfio/pds: Fix missing detach_ioas op

On Wed, 2 Jul 2025 09:37:44 -0700
Brett Creeley <brett.creeley@....com> wrote:

> When CONFIG_IOMMUFD is enabled and a device is bound to the pds_vfio_pci
> driver, the following WARN_ON() trace is seen and probe fails:
> 
> WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317 __vfio_register_dev+0x130/0x140 [vfio]
> <...>
> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -22
> 
> This is because the driver's vfio_device_ops.detach_ioas isn't set.
> 
> Fix this by using the generic vfio_iommufd_physical_detach_ioas
> function.
> 
> Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> ---
>  drivers/vfio/pci/pds/vfio_dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c
> index 76a80ae7087b..f6e0253a8a14 100644
> --- a/drivers/vfio/pci/pds/vfio_dev.c
> +++ b/drivers/vfio/pci/pds/vfio_dev.c
> @@ -204,6 +204,7 @@ static const struct vfio_device_ops pds_vfio_ops = {
>  	.bind_iommufd = vfio_iommufd_physical_bind,
>  	.unbind_iommufd = vfio_iommufd_physical_unbind,
>  	.attach_ioas = vfio_iommufd_physical_attach_ioas,
> +	.detach_ioas = vfio_iommufd_physical_detach_ioas,
>  };
>  
>  const struct vfio_device_ops *pds_vfio_ops_info(void)

Applied to vfio next branch for v6.17.  Thanks,

Alex