linux-kernel - Re: [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250703072317.GK41770@horms.kernel.org>
Date: Thu, 3 Jul 2025 08:23:17 +0100
From: Simon Horman <horms@...nel.org>
To: Vivian Wang <wangruikang@...as.ac.cn>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Vivian Wang <uwu@...m.page>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1

On Wed, Jul 02, 2025 at 02:01:39PM +0800, Vivian Wang wrote:
> SpacemiT K1 has two gigabit Ethernet MACs with RGMII and RMII support.
> Add a driver for them, as well as the supporting devicetree and bindings
> updates.
> 
> Tested on BananaPi BPI-F3 and Milk-V Jupiter.
> 
> I would like to note that even though some bit field names superficially
> resemble that of DesignWare MAC, all other differences point to it in
> fact being a custom design.
> 
> Based on SpacemiT drivers [1].
> 
> This series depends on reset controller support [2] and DMA buses [3]
> for K1. There are some minor conflicts resulting from both touching
> k1.dtsi, but it should just both be adding nodes.
> 
> These patches can also be pulled from:
> 
> https://github.com/dramforever/linux/tree/k1/ethernet/v3
> 
> [1]: https://github.com/spacemit-com/linux-k1x
> [2]: https://lore.kernel.org/all/20250613011139.1201702-1-elder@riscstar.com
> [3]: https://lore.kernel.org/all/20250623-k1-dma-buses-rfc-wip-v1-0-c0144082061f@iscas.ac.cn
> 
> ---
> Changes in v3:
> - Refactored and simplified emac_tx_mem_map
> - Addressed other minor v2 review comments
> - Removed what was patch 3 in v2, depend on DMA buses instead
> - DT nodes in alphabetical order where appropriate
> - Link to v2: https://lore.kernel.org/r/20250618-net-k1-emac-v2-0-94f5f07227a8@iscas.ac.cn
> 
> Changes in v2:
> - dts: Put eth0 and eth1 nodes under a bus with dma-ranges
> - dts: Added Milk-V Jupiter
> - Fix typo in emac_init_hw() that broke the driver (Oops!)
> - Reformatted line lengths to under 80
> - Addressed other v1 review comments
> - Link to v1: https://lore.kernel.org/r/20250613-net-k1-emac-v1-0-cc6f9e510667@iscas.ac.cn
> 
> ---
> Vivian Wang (5):
>       dt-bindings: net: Add support for SpacemiT K1
>       net: spacemit: Add K1 Ethernet MAC
>       riscv: dts: spacemit: Add Ethernet support for K1
>       riscv: dts: spacemit: Add Ethernet support for BPI-F3
>       riscv: dts: spacemit: Add Ethernet support for Jupiter

I'm unsure on the plan for merging this.  But it seems to me that the first
two patches ought to go though net-next. But in order for patches to
proceed through net-next the entire series ought to apply on that tree - so
CI can run.

I'm not sure on the way forward.  But perhaps splitting the series in two:
the first two patches for net-next; and, the riscv patches targeted elsewhere
makes sense?

</2c>