linux-kernel - Re: [PATCH v3 1/3] i2c: stm32: fix the device used for the DMA map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44f4f1a4-0225-4fda-b17b-f3159e00851d@foss.st.com>
Date: Thu, 3 Jul 2025 09:20:26 +0200
From: Clement LE GOFFIC <clement.legoffic@...s.st.com>
To: Andi Shyti <andi.shyti@...nel.org>
CC: Pierre-Yves MORDRET <pierre-yves.mordret@...s.st.com>,
        Alain Volmat
	<alain.volmat@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Sumit Semwal
	<sumit.semwal@...aro.org>,
        Christian König
	<christian.koenig@....com>,
        M'boumba Cedric Madianga
	<cedric.madianga@...il.com>,
        Wolfram Sang <wsa@...nel.org>,
        "Pierre-Yves
 MORDRET" <pierre-yves.mordret@...com>,
        <linux-i2c@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH v3 1/3] i2c: stm32: fix the device used for the DMA map

Hi Andy,

On 7/2/25 18:57, Andi Shyti wrote:
> Hi Clement,
> 
> ...
> 
>> @@ -118,7 +118,7 @@ int stm32_i2c_prep_dma_xfer(struct device *dev, struct stm32_i2c_dma *dma,
>>   	dma->dma_len = len;
>>   	chan_dev = dma->chan_using->device->dev;
>>   
>> -	dma->dma_buf = dma_map_single(chan_dev, buf, dma->dma_len,
>> +	dma->dma_buf = dma_map_single(dev, buf, dma->dma_len,
>>   				      dma->dma_data_dir);
>>   	if (dma_mapping_error(chan_dev, dma->dma_buf)) {
> 			      ^^^^^^^^
> 
> this one should be "dev" too, which renders the chan_dev variable
> unused.

Oh yes will send a v4

Best regards,
Clément