linux-kernel - Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e08ec21-e863-4720-8604-df0640624a83@kernel.org>
Date: Thu, 3 Jul 2025 10:03:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>,
 lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, shenghao-ding@...com,
 kevin-lu@...com, baojun.xu@...com, perex@...ex.cz, tiwai@...e.com,
 matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, m.felsch@...gutronix.de,
 bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity

On 03/07/2025 09:50, Catalin Popescu wrote:
> Both TAS2563 & TAS2781 have an active low reset, yet the driver assumes
> an active high reset. Hence, in order to get the chip out of reset we
> need to lie to the devicetree about the reset polarity. The patch fixes
> the driver so it could work no matter the polarity and leaves it to the
> devicetree to define the correct polarity.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>


This breaks all existing in-tree and out-tree users.

DTS patches are independent, so you cannot fix in-tree that way. Anyway,
you cannot fix other users, so sorry, you are stuck with this or you
need some tricks (I once did for a qcom codec, but I don't know if this
is really the solution and my case was easier about the users).

Best regards,
Krzysztof