linux-kernel - Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72ba4fbe-eb2c-4e8a-8118-9b264af04f31@leica-geosystems.com>
Date: Thu, 3 Jul 2025 12:29:26 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "lgirdwood@...il.com"
	<lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"shenghao-ding@...com" <shenghao-ding@...com>, "kevin-lu@...com"
	<kevin-lu@...com>, "baojun.xu@...com" <baojun.xu@...com>, "perex@...ex.cz"
	<perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "m.felsch@...gutronix.de"
	<m.felsch@...gutronix.de>, GEO-CHHER-bsp-development
	<bsp-development.geo@...ca-geosystems.com>
Subject: Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity

On 03/07/2025 10:03, Krzysztof Kozlowski wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 03/07/2025 09:50, Catalin Popescu wrote:
>> Both TAS2563 & TAS2781 have an active low reset, yet the driver assumes
>> an active high reset. Hence, in order to get the chip out of reset we
>> need to lie to the devicetree about the reset polarity. The patch fixes
>> the driver so it could work no matter the polarity and leaves it to the
>> devicetree to define the correct polarity.
>>
>> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
>
> This breaks all existing in-tree and out-tree users.
>
> DTS patches are independent, so you cannot fix in-tree that way. Anyway,
> you cannot fix other users, so sorry, you are stuck with this or you
> need some tricks (I once did for a qcom codec, but I don't know if this
> is really the solution and my case was easier about the users).
>
> Best regards,
> Krzysztof

Then, I'll keep lying to my devicetree and stick with the current driver.
Thx for the review!

BR,
Catalin