linux-kernel - Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fa30d8f-8737-4bda-a5dd-d7deb8f0896c@quicinc.com>
Date: Thu, 3 Jul 2025 16:48:46 +0530
From: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Srinivas Kandagatla <srini@...nel.org>,
        Liam Girdwood
	<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>
CC: <cros-qcom-dts-watchers@...omium.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-sound@...r.kernel.org>,
        <kernel@....qualcomm.com>, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro:
 Update bindings for clocks to support ADSP



On 6/25/2025 2:14 PM, Krzysztof Kozlowski wrote:
> On 25/06/2025 10:29, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>>
>> Manage clock settings for ADSP solution.
>>
>> On Existing ADSP bypass solutions, The macro and dcodec GDSCs are
> 
> s/The/the/

Ack.

> 
> OK, this has to be expressed in schema - oneOf in top-level for presence
> (required) power domains or clocks (contains for these names).

Will check and update.

> 
> 
>> enabled using power domains in lpass-va-macro which is not applicable
>> for ADSP based platform.
>>
>> Reference:
>>   - qcom,lpass-tx-macro.yaml
>>   - qcom,lpass-rx-macro.yaml
> 
> I don't understand this reference.

Please refer below link for more info. Which is similar kind of 
properties used.

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml#n72

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml#n77

> 
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> ---
>>   .../bindings/sound/qcom,lpass-va-macro.yaml        | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> index f41deaa6f4df..38679a4f21fa 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> @@ -75,14 +75,20 @@ allOf:
>>           compatible:
>>             contains:
>>               const: qcom,sc7280-lpass-va-macro
>> +
> 
> Why? It's a different style now. Don't introduce random whitespace changes.

Ack.

Thanks,
Prasad

> 
> 
> Best regards,
> Krzysztof