linux-kernel - Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdc33ace-0979-426e-a1db-b90c8310e8af@kernel.org>
Date: Thu, 3 Jul 2025 13:35:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 kernel@....qualcomm.com, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro:
 Update bindings for clocks to support ADSP

On 03/07/2025 13:18, Prasad Kumpatla wrote:
>>
>>> enabled using power domains in lpass-va-macro which is not applicable
>>> for ADSP based platform.
>>>
>>> Reference:
>>>   - qcom,lpass-tx-macro.yaml
>>>   - qcom,lpass-rx-macro.yaml
>>
>> I don't understand this reference.
> 
> Please refer below link for more info. Which is similar kind of 
> properties used.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml#n72
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml#n77
I don't understand what is has to do with commit msg. Please
explain/describe in the commit msg the hardware, not point to external
references. No one is going to look to other files to understand why
this commit is like that. This commit must stand on its own.

Best regards,
Krzysztof