linux-kernel - Re: [PATCH v9 1/6] KVM: arm64: Rename the device variable to s2_force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <126f839c-f0e5-42a4-a172-2cefd59e5750@redhat.com>
Date: Fri, 4 Jul 2025 15:57:17 +0200
From: David Hildenbrand <david@...hat.com>
To: ankita@...dia.com, jgg@...dia.com, maz@...nel.org,
 oliver.upton@...ux.dev, joey.gouly@....com, suzuki.poulose@....com,
 yuzenghui@...wei.com, catalin.marinas@....com, will@...nel.org,
 ryan.roberts@....com, shahuang@...hat.com, lpieralisi@...nel.org,
 ddutile@...hat.com, seanjc@...gle.com
Cc: aniketa@...dia.com, cjia@...dia.com, kwankhede@...dia.com,
 kjaju@...dia.com, targupta@...dia.com, vsethi@...dia.com,
 acurrid@...dia.com, apopple@...dia.com, jhubbard@...dia.com,
 danw@...dia.com, zhiw@...dia.com, mochs@...dia.com, udhoke@...dia.com,
 dnigam@...dia.com, alex.williamson@...hat.com, sebastianene@...gle.com,
 coltonlewis@...gle.com, kevin.tian@...el.com, yi.l.liu@...el.com,
 ardb@...nel.org, akpm@...ux-foundation.org, gshan@...hat.com,
 linux-mm@...ck.org, tabba@...gle.com, qperret@...gle.com,
 kvmarm@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, maobibo@...ngson.cn
Subject: Re: [PATCH v9 1/6] KVM: arm64: Rename the device variable to
 s2_force_noncacheable

On 21.06.25 06:21, ankita@...dia.com wrote:
> From: Ankit Agrawal <ankita@...dia.com>
> 
> For cache maintenance on a region, ARM KVM relies on that
> region to be mapped to the Kernal virtual address as CMOs
> operate on VA.
> 
> Currently the device variable is effectively trying to setup
> the S2 mapping as non cacheable for memory regions that are
> not mapped in the Kernel VA. This could be either device or
> Normal_NC depending on the VM_ALLOW_ANY_UNCACHED flag in the
> VMA.
> 
> Thus "device" could be better renamed to s2_force_noncacheable
> which implies that it is ensuring that region be mapped as
> non-cacheable.
> 
> CC: Catalin Marinas <catalin.marinas@....com>
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Ankit Agrawal <ankita@...dia.com>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb