linux-kernel - Re: [PATCH] locking/mutex: remove redundant ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a687f94-770b-4fa8-83be-978007e902b6@redhat.com>
Date: Fri, 4 Jul 2025 09:57:35 -0400
From: Waiman Long <llong@...hat.com>
To: ranxiaokai627@....com, peterz@...radead.org, mingo@...hat.com,
 will@...nel.org, boqun.feng@...il.com
Cc: linux-kernel@...r.kernel.org, ran.xiaokai@....com.cn
Subject: Re: [PATCH] locking/mutex: remove redundant ifdef


On 7/3/25 9:52 PM, ranxiaokai627@....com wrote:
> From: Ran Xiaokai <ran.xiaokai@....com.cn>
>
> hung_task_set/clear_blocker() is already guarded by
> CONFIG_DETECT_HUNG_TASK_BLOCKER in hung_task.h, So remove
> the redudant check of #ifdef.
>
> Signed-off-by: Ran Xiaokai <ran.xiaokai@....com.cn>
> ---
>   kernel/locking/mutex.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> index a39ecccbd106..d4210dc97b6a 100644
> --- a/kernel/locking/mutex.c
> +++ b/kernel/locking/mutex.c
> @@ -191,9 +191,7 @@ static void
>   __mutex_add_waiter(struct mutex *lock, struct mutex_waiter *waiter,
>   		   struct list_head *list)
>   {
> -#ifdef CONFIG_DETECT_HUNG_TASK_BLOCKER
>   	hung_task_set_blocker(lock, BLOCKER_TYPE_MUTEX);
> -#endif
>   	debug_mutex_add_waiter(lock, waiter, current);
>   
>   	list_add_tail(&waiter->list, list);
> @@ -209,9 +207,7 @@ __mutex_remove_waiter(struct mutex *lock, struct mutex_waiter *waiter)
>   		__mutex_clear_flag(lock, MUTEX_FLAGS);
>   
>   	debug_mutex_remove_waiter(lock, waiter, current);
> -#ifdef CONFIG_DETECT_HUNG_TASK_BLOCKER
>   	hung_task_clear_blocker();
> -#endif
>   }
>   
>   /*
Acked-by: Waiman Long <longman@...hat.com>