linux-kernel - Re: [PATCH v3 2/2] iio: imu: smi330: Add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507042238.UDo16CzT-lkp@intel.com>
Date: Fri, 4 Jul 2025 22:23:31 +0800
From: kernel test robot <lkp@...el.com>
To: Jianping.Shen@...bosch.com, jic23@...nel.org, lars@...afoo.de,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	dima.fedrau@...il.com, marcelo.schmitt1@...il.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Christian.Lorenz3@...bosch.com,
	Ulrike.Frauendorf@...bosch.com, Kai.Dolde@...bosch.com
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v3 2/2] iio: imu: smi330: Add driver

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.16-rc4 next-20250704]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jianping-Shen-de-bosch-com/dt-bindings-iio-imu-smi330-Add-binding/20250703-234441
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20250703153823.806073-3-Jianping.Shen%40de.bosch.com
patch subject: [PATCH v3 2/2] iio: imu: smi330: Add driver
config: microblaze-randconfig-r073-20250704 (https://download.01.org/0day-ci/archive/20250704/202507042238.UDo16CzT-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250704/202507042238.UDo16CzT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507042238.UDo16CzT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iio/imu/smi330/smi330_i2c.c: In function 'smi330_regmap_i2c_read':
>> drivers/iio/imu/smi330/smi330_i2c.c:26:11: warning: unused variable 'retry' [-Wunused-variable]
     int ret, retry;
              ^~~~~


vim +/retry +26 drivers/iio/imu/smi330/smi330_i2c.c

    20	
    21	static int smi330_regmap_i2c_read(void *context, const void *reg_buf,
    22					  size_t reg_size, void *val_buf,
    23					  size_t val_size)
    24	{
    25		struct smi330_i2c_priv *priv = context;
  > 26		int ret, retry;
    27	
    28		/*
    29		 * SMI330 I2C read frame:
    30		 * <Slave address[6:0], RnW> <x, Register address[6:0]>
    31		 * <Slave address[6:0], RnW> <Dummy[7:0]> <Dummy[7:0]> <Data_0[7:0]> <Data_1[15:8]>...
    32		 *                                                     <Data_N[7:0]> <Data_N[15:8]>
    33		 * Remark: Slave address is not considered part of the frame in the following definitions
    34		 */
    35		struct i2c_msg msgs[] = {
    36			{
    37				.addr = priv->i2c->addr,
    38				.flags = priv->i2c->flags,
    39				.len = reg_size,
    40				.buf = (u8 *)reg_buf,
    41			},
    42			{
    43				.addr = priv->i2c->addr,
    44				.flags = priv->i2c->flags | I2C_M_RD,
    45				.len = SMI330_NUM_DUMMY_BYTES + val_size,
    46				.buf = priv->rx_buffer,
    47			},
    48		};
    49	
    50		ret = i2c_transfer(priv->i2c->adapter, msgs, ARRAY_SIZE(msgs));
    51		if (ret < 0)
    52			return ret;
    53	
    54		memcpy(val_buf, priv->rx_buffer + SMI330_NUM_DUMMY_BYTES, val_size);
    55	
    56		return 0;
    57	}
    58	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki