linux-kernel - Re: [PATCH 32/80] iio: gyro: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DB3DJ9O7DEH9.377Y1IS7ZAVHV@linaro.com>
Date: Fri, 04 Jul 2025 16:25:57 +0100
From: Rui Miguel Silva <rmfrfs@...il.com>
To: "Sakari Ailus" <sakari.ailus@...ux.intel.com>, "Jonathan Cameron"
 <jic23@...nel.org>, "David Lechner" <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>, "Andy Shevchenko"
 <andy@...nel.org>, "Rui Miguel Silva" <rmfrfs@...il.com>, "Linus Walleij"
 <linus.walleij@...aro.org>, "Julien Stephan" <jstephan@...libre.com>, "Hans
 de Goede" <hansg@...nel.org>, "Waqar Hameed" <waqar.hameed@...s.com>
Cc: <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 32/80] iio: gyro: Remove redundant
 pm_runtime_mark_last_busy() calls

Hi Sakari,
Thanks for the patch
On Fri Jul 4, 2025 at 8:54 AM WEST, Sakari Ailus wrote:

> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---
> The cover letter of the set can be found here
> <URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ailus@linux.intel.com>.
>
> In brief, this patch depends on PM runtime patches adding marking the last
> busy timestamp in autosuspend related functions. The patches are here, on
> rc2:
>
>         git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
>                 pm-runtime-6.17-rc1
>
>  drivers/iio/gyro/bmg160_core.c     | 1 -
>  drivers/iio/gyro/fxas21002c_core.c | 2 --
>  drivers/iio/gyro/mpu3050-core.c    | 3 ---
>  drivers/iio/gyro/mpu3050-i2c.c     | 1 -
>  4 files changed, 7 deletions(-)
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 781d3e96645f..4dbe3c0cc5eb 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -310,7 +310,6 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on)
>  	if (on)
>  		ret = pm_runtime_get_sync(dev);
>  	else {
> -		pm_runtime_mark_last_busy(dev);
>  		ret = pm_runtime_put_autosuspend(dev);
>  	}
>  
> diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c
> index 754c8a564ba4..a88670207cec 100644
> --- a/drivers/iio/gyro/fxas21002c_core.c
> +++ b/drivers/iio/gyro/fxas21002c_core.c
> @@ -373,8 +373,6 @@ static int  fxas21002c_pm_put(struct fxas21002c_data *data)
>  {
>  	struct device *dev = regmap_get_device(data->regmap);
>  
> -	pm_runtime_mark_last_busy(dev);
> -
>  	return pm_runtime_put_autosuspend(dev);
>  }

LGTM,
Reviewed-by: Rui Miguel Silva <rui.silva@...aro.org>

Cheers,
   Rui