linux-kernel - Re: [PATCH 41/80] media: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGfwWkZg48T1tooH@gofer.mess.org>
Date: Fri, 4 Jul 2025 16:16:42 +0100
From: Sean Young <sean@...s.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Tommaso Merciai <tomm.merciai@...il.com>,
	Martin Hecht <mhecht73@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Alain Volmat <alain.volmat@...s.st.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Umang Jain <umang.jain@...asonboard.com>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Michael Riesch <michael.riesch@...labora.com>,
	Mikhail Rudenko <mike.rudenko@...il.com>,
	Steve Longerbeam <slongerbeam@...il.com>,
	Jacopo Mondi <jacopo.mondi@...asonboard.com>,
	Nicholas Roth <nicholas@...hemail.net>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Paul Elder <paul.elder@...asonboard.com>,
	Matt Ranostay <matt@...ostay.sg>,
	Nas Chung <nas.chung@...psnmedia.com>,
	Jackson Lee <jackson.lee@...psnmedia.com>,
	Dmitry Osipenko <digetx@...il.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Vikash Garodia <quic_vgarodia@...cinc.com>,
	Dikshita Agarwal <quic_dikshita@...cinc.com>,
	Abhinav Kumar <abhinav.kumar@...ux.dev>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Nicolas Dufresne <nicolas.dufresne@...labora.com>,
	Benjamin Gaignard <benjamin.gaignard@...labora.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Hans Verkuil <hverkuil@...all.nl>,
	Matthias Fend <matthias.fend@...end.at>,
	Marco Felsch <m.felsch@...gutronix.de>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 41/80] media: Remove redundant
 pm_runtime_mark_last_busy() calls

On Fri, Jul 04, 2025 at 10:54:31AM +0300, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---
 
...

>  diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
> index bf6d8fa983bf..161f8919022c 100644
> --- a/drivers/media/rc/gpio-ir-recv.c
> +++ b/drivers/media/rc/gpio-ir-recv.c
> @@ -49,7 +49,6 @@ static irqreturn_t gpio_ir_recv_irq(int irq, void *dev_id)
>  		ir_raw_event_store_edge(gpio_dev->rcdev, val == 1);
>  
>  	if (pmdev) {
> -		pm_runtime_mark_last_busy(pmdev);
>  		pm_runtime_put_autosuspend(pmdev);
>  	}

No need for braces any more - as Laurent already pointed out.

Reviewed-by: Sean Young <sean@...s.org>


Sean