linux-kernel - Re: [PATCH v1 3/4] ASoC: dt-bindings: Add dt bindings for FS2104/5S audio amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <021E47BD8882DB2D+aGeCJvwdYAs8pny9@foursemi.com>
Date: Fri, 4 Jul 2025 15:26:30 +0800
From: Nick Li <nick.li@...rsemi.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, perex@...ex.cz,
	tiwai@...e.com, xiaoming.yang@...rsemi.com,
	danyang.zheng@...rsemi.com, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/4] ASoC: dt-bindings: Add dt bindings for FS2104/5S
 audio amplifiers

On Thu, Jul 03, 2025 at 09:15:36AM +0200, Krzysztof Kozlowski wrote:
> On 03/07/2025 09:10, Krzysztof Kozlowski wrote:
> > On Thu, Jul 03, 2025 at 11:56:38AM +0800, Nick wrote:
> >> From: Nick Li <nick.li@...rsemi.com>
> >>
> >> This patch adds bindings for FourSemi FS2104/5S audio amplifiers
> >> which can support both I2S and I2C interface.
> >>
> >> Signed-off-by: Nick Li <nick.li@...rsemi.com>
> >> ---
> >>  .../bindings/sound/foursemi,fs210x.yaml       | 95 +++++++++++++++++++
> >>  1 file changed, 95 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml b/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> >> new file mode 100644
> >> index 000000000..3a1aba9b8
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/sound/foursemi,fs210x.yaml
> >> @@ -0,0 +1,95 @@
> >> +# SPDX-License-Identifier: GPL-2.0-only
> > 
> > Please run scripts/checkpatch.pl on the patches and fix reported
> > warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> > patches and (probably) fix more warnings. Some warnings can be ignored,
> > especially from --strict run, but the code here looks like it needs a
> > fix. Feel free to get in touch if the warning is not clear.
> 
> 
> One more thing: Drop "dt-bindings for" from subject.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

OK, update it in next version.

> 
> 
> ... and that was my third email today... I apologize I did not send
> these as one review email, that's not really professional from my side
> but somehow coffee did not work good this morning.
> 

Thank you for taking your valuable time to review the code.

Best regards,
Nick

> Best regards,
> Krzysztof
>