linux-kernel - Re: [PATCH v8 2/3] staging: media: atomisp: fix indentation in anr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdd8aOhQ73opych5WohuM2CXq2dPgdgHW0ZdYHRU=u5WQ@mail.gmail.com>
Date: Sat, 5 Jul 2025 21:05:40 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v8 2/3] staging: media: atomisp: fix indentation in anr

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@...il.com> wrote:
>
> This patch fixes tab/space indentation issues in anr
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

> -       {
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4
> -       },
> +       { 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4 },

This change is not okay. Please, leave the curly braces on their own lines.

> -       {10, 20, 30}
> +       { 10, 20, 30 }

This is okay, but also makes sense to add a trailing comma.

...

>  void
> -ia_css_anr_encode(
> -    struct sh_css_isp_anr_params *to,
> -    const struct ia_css_anr_config *from,
> -    unsigned int size);
> +ia_css_anr_encode(struct sh_css_isp_anr_params *to,
> +                 const struct ia_css_anr_config *from,
> +                 unsigned int size);

Don't we want to have something like

void ia_css_anr_encode(struct sh_css_isp_anr_params *to,
                      const struct ia_css_anr_config *from,
                      unsigned int size);

?

Ditto for other similar cases.

...

>  /* Application specific DMA settings  */
> -#define ANR_BPP                 10
> -#define ANR_ELEMENT_BITS        ((CEIL_DIV(ANR_BPP, 8)) * 8)
> +#define ANR_BPP 10
> +#define ANR_ELEMENT_BITS ((CEIL_DIV(ANR_BPP, 8)) * 8)

Doesn't look like a good change.

-- 
With Best Regards,
Andy Shevchenko