linux-kernel - Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfc7QsENHsaYMKau_4DU3-LmW2XaUxd=oHqTS3F3R85eg@mail.gmail.com>
Date: Sat, 5 Jul 2025 21:07:33 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@...il.com> wrote:
>
> This patch fixes tab/space indentation issues in aa
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>   *     ISP2: BAA2 is used.
>   */
>  struct ia_css_aa_config {
> -       u16 strength;   /** Strength of the filter.
> +       u16 strength; /** Strength of the filter.
>                                         u0.13, [0,8191],
>                                         default/ineffective 0 */
>  };

This seems to be a kernel-doc format. Instead of fixing this, move the
description of the field to the top comment and make sure it follows
kernel-doc. In such case the change will be much more useful.

-- 
With Best Regards,
Andy Shevchenko