linux-kernel - Re: [PATCH v8 3/3] staging: media: atomisp: fix indentation in bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve7y3pmZ5g8YXLNHyZgmZpiZNAuDdNfmhxYTOATrDBz5Q@mail.gmail.com>
Date: Sat, 5 Jul 2025 21:10:03 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v8 3/3] staging: media: atomisp: fix indentation in bh

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@...il.com> wrote:
>
> This patch fixes tab/space indentation issues in bh
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>  void
> -ia_css_bh_hmem_decode(
> -    struct ia_css_3a_rgby_output *out_ptr,
> -    const struct ia_css_bh_table *hmem_buf)
> +ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
> +                     const struct ia_css_bh_table *hmem_buf)

Same comment as per previous patch.

...

>         to->y_coef_r =
> -           uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_g =
> -           uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_b =
> -           uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);

Not sure what's going on here. But I think this is just a churn.

...

> -#define IA_CSS_HMEM_BH_TABLE_SIZE      ISP_HIST_DEPTH
> -#define IA_CSS_HMEM_BH_UNIT_SIZE       (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
> +#define IA_CSS_HMEM_BH_TABLE_SIZE ISP_HIST_DEPTH
> +#define IA_CSS_HMEM_BH_UNIT_SIZE (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
>
> -#define BH_COLOR_R     (0)
> -#define BH_COLOR_G     (1)
> -#define BH_COLOR_B     (2)
> -#define BH_COLOR_Y     (3)
> -#define BH_COLOR_NUM   (4)
> +#define BH_COLOR_R (0)
> +#define BH_COLOR_G (1)
> +#define BH_COLOR_B (2)
> +#define BH_COLOR_Y (3)
> +#define BH_COLOR_NUM (4)

Doesn't look like a good change.

-- 
With Best Regards,
Andy Shevchenko