lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4648f0bf-2957-45bf-a6c1-01787e5d3e88@kernel.org>
Date: Sun, 6 Jul 2025 11:46:46 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukas Schmid <lukas.schmid@...cube.li>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, Maxime Ripard <mripard@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v1 3/7] dt-bindings: arm: sunxi: Add NetCube Systems
 Nagami Keypad Carrier Board

On 06/07/2025 11:41, Lukas Schmid wrote:
> On Sonntag, 6. Juli 2025 11:36:34 CEST Krzysztof Kozlowski wrote:
>> On 06/07/2025 11:07, Lukas Schmid wrote:
>>> On Sonntag, 6. Juli 2025 09:49:58 CEST Krzysztof Kozlowski wrote:
>>>> On 05/07/2025 23:38, Lukas Schmid wrote:
>>>>> The NetCube Systems Nagami Keypad Carrier is a custom board intended to
>>>>> fit a standard Ritto Intercom enclosure and provides a Keypad,
>>>>> NFC-Reader
>>>>> and Status-LED all controllable over Ethernet with PoE support.
>>>>>
>>>>> Signed-off-by: Lukas Schmid <lukas.schmid@...cube.li>
>>>>> ---
>>>>>
>>>>>  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>> b/Documentation/devicetree/bindings/arm/sunxi.yaml index
>>>>> 7919b5bf5..a2f16d064 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>>
>>>>> @@ -610,6 +610,12 @@ properties:
>>>>>            - const: netcube,nagami
>>>>>            - const: allwinner,sun8i-t113s
>>>>>
>>>>> +      - description: NetCube Systems Nagami Keypad Carrier Board
>>>>> +        items:
>>>>> +          - const: netcube,nagami-keypad-carrier
>>>>
>>>> That's just enum with previous entry. Don't make it over-complicated.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Just making sure here. The actual bindings are fine, but I should merge
>>> them into one patch, correct?
>>
>> No, you got two comments what should be changed in the binding.
>>
>> Best regards,
>> Krzysztof
> 
> So if I understand correctly you want me to remove the "allwinner,sun8i-t113s" 
> from the carrier boards and keep it for the SoM?
No, I spoke nothing about that compatible. My comment is EXACTLY under
the line being incorrect. That entry should have been made enum with
previous board compatible. Look at other vendors, because this file
repeats that pattern for some reason, eh...

Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ