[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72kUoyhbwiTeB3Bwv3X0iGLbiVWeQCBvKshOaNMqkEsUPw@mail.gmail.com>
Date: Sun, 6 Jul 2025 15:42:13 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Jonathan Corbet <corbet@....net>, nouveau@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, rust-for-linux@...r.kernel.org,
Joel Fernandes <joelagnelf@...dia.com>
Subject: Re: [PATCH v3 1/7] gpu: nova-core: Add code comments related to devinit
On Wed, Jul 2, 2025 at 1:04 PM Alexandre Courbot <acourbot@...dia.com> wrote:
>
> + // Check that FWSEC has lowered its protection level before reading the GFW_BOOT status.
`GFW_BOOT` (another one below), since it is written like that above.
> -/* PGC6 */
> +/*
> + * PGC6 register space.
> + *
> + * `GC6` is a GPU low-power state where VRAM is in self-refresh and the GPU is powered down (except
> + * for power rails needed to keep self-refresh working and important registers and hardware
> + * blocks).
> + *
> + * These scratch registers remain powered on even in a low-power state and have a designated group
> + * number.
> + */
I noticed the file uses `/*` in a couple files -- could `//` be used
or there is a reason for it?
(I guess maybe in a different series, since it is already there for
PMC in mainline. It could be a good first issue.)
The idea is to only use `/*` when `//` cannot be used, e.g. within
code, so that they have a different purpose.
Cheers,
Miguel
Powered by blists - more mailing lists