linux-kernel - Re: [PATCH v3 2/7] gpu: nova-core: Clarify sysmembar operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nh71s9to5v1KHJWN79bEFv97zN6jcGJyEQkaJZ5UuJfg@mail.gmail.com>
Date: Sun, 6 Jul 2025 15:46:12 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Jonathan Corbet <corbet@....net>, nouveau@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	Joel Fernandes <joelagnelf@...dia.com>
Subject: Re: [PATCH v3 2/7] gpu: nova-core: Clarify sysmembar operations

On Wed, Jul 2, 2025 at 1:05 PM Alexandre Courbot <acourbot@...dia.com> wrote:
>
> +/// driver initialization, and before any falcon is reset.
> +//
>  /// Users are responsible for manually calling [`Self::unregister`] before dropping this object,

Missing slash.

Added the possibility of catching this automatically in e.g. `rustdoc` to:

    https://github.com/Rust-for-Linux/linux/issues/350

> +// These two registers together hold the physical system memory address that is used by the GPU for
> +// perform sysmembar operation (see [`crate::fb::SysmemFlush`]).

This is a normal comment, so the intra-doc link will (sadly) not do anything.

Cheers,
Miguel