linux-kernel - Re: [PATCH 3/4 V2] Staging: media: atomisp: i2c: struct definition style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <079b73bf-c266-4ffc-8adc-488dfd2c53f9@kernel.org>
Date: Sun, 6 Jul 2025 17:01:14 +0200
From: Hans de Goede <hansg@...nel.org>
To: Thomas Andreatta <thomasandreatta2000@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
 Thomas Andreatta <thomas.andreatta2000@...il.com>
Subject: Re: [PATCH 3/4 V2] Staging: media: atomisp: i2c: struct definition
 style

Hi,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Reorder const qualifier in array declaration
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@...il.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  drivers/staging/media/atomisp/i2c/gc2235.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h
> index 6c743a17f198..7dd9a676fb98 100644
> --- a/drivers/staging/media/atomisp/i2c/gc2235.h
> +++ b/drivers/staging/media/atomisp/i2c/gc2235.h
> @@ -179,21 +179,21 @@ struct gc2235_write_ctrl {
>  	struct gc2235_write_buffer buffer;
>  };
>  
> -static struct gc2235_reg const gc2235_stream_on[] = {
> +static const struct gc2235_reg gc2235_stream_on[] = {
>  	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
>  	{ GC2235_8BIT, 0x10, 0x91}, /* start mipi */
>  	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_stream_off[] = {
> +static const struct gc2235_reg gc2235_stream_off[] = {
>  	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
>  	{ GC2235_8BIT, 0x10, 0x01}, /* stop mipi */
>  	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_init_settings[] = {
> +static const struct gc2235_reg gc2235_init_settings[] = {
>  	/* System */
>  	{ GC2235_8BIT, 0xfe, 0x80 },
>  	{ GC2235_8BIT, 0xfe, 0x80 },
> @@ -268,7 +268,7 @@ static struct gc2235_reg const gc2235_init_settings[] = {
>   * Register settings for various resolution
>   */
>  #if ENABLE_NON_PREVIEW
> -static struct gc2235_reg const gc2235_1296_736_30fps[] = {
> +static const struct gc2235_reg gc2235_1296_736_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -321,7 +321,7 @@ static struct gc2235_reg const gc2235_1296_736_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_960_640_30fps[] = {
> +static const struct gc2235_reg gc2235_960_640_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -373,7 +373,7 @@ static struct gc2235_reg const gc2235_960_640_30fps[] = {
>  };
>  #endif
>  
> -static struct gc2235_reg const gc2235_1600_900_30fps[] = {
> +static const struct gc2235_reg gc2235_1600_900_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -418,7 +418,7 @@ static struct gc2235_reg const gc2235_1600_900_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
> +static const struct gc2235_reg gc2235_1616_1082_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -463,7 +463,7 @@ static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_1616_1216_30fps[] = {
> +static const struct gc2235_reg gc2235_1616_1216_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>