linux-kernel - Re: [PATCH 4/4 V2] Staging: media: atomisp: i2c: struct definition style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec2cf624-5849-4491-8a3f-2070d2766ec6@kernel.org>
Date: Sun, 6 Jul 2025 17:01:26 +0200
From: Hans de Goede <hansg@...nel.org>
To: Thomas Andreatta <thomasandreatta2000@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
 Thomas Andreatta <thomas.andreatta2000@...il.com>
Subject: Re: [PATCH 4/4 V2] Staging: media: atomisp: i2c: struct definition
 style

Hi,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Reorder const qualifier in array declaration
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@...il.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  drivers/staging/media/atomisp/i2c/ov2722.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index bc36133f3722..00317d105305 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -236,7 +236,7 @@ struct ov2722_write_ctrl {
>   * Register settings for various resolution
>   */
>  #if 0
> -static struct ov2722_reg const ov2722_QVGA_30fps[] = {
> +static const struct ov2722_reg ov2722_QVGA_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x0c},
>  	{OV2722_8BIT, 0x373a, 0x1c},
> @@ -346,7 +346,7 @@ static struct ov2722_reg const ov2722_QVGA_30fps[] = {
>  
>  };
>  
> -static struct ov2722_reg const ov2722_480P_30fps[] = {
> +static const struct ov2722_reg ov2722_480P_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x18},
>  	{OV2722_8BIT, 0x373a, 0x3c},
> @@ -455,7 +455,7 @@ static struct ov2722_reg const ov2722_480P_30fps[] = {
>  	{OV2722_TOK_TERM, 0, 0},
>  };
>  
> -static struct ov2722_reg const ov2722_VGA_30fps[] = {
> +static const struct ov2722_reg ov2722_VGA_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x18},
>  	{OV2722_8BIT, 0x373a, 0x3c},
> @@ -565,7 +565,7 @@ static struct ov2722_reg const ov2722_VGA_30fps[] = {
>  };
>  #endif
>  
> -static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
> +static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
>  				a whole frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -667,7 +667,7 @@ static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
>  	{OV2722_TOK_TERM, 0, 0}
>  };
>  
> -static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
> +static const struct ov2722_reg ov2722_1452_1092_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
>  				a whole frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -769,7 +769,7 @@ static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
>  };
>  
>  #if 0
> -static struct ov2722_reg const ov2722_1M3_30fps[] = {
> +static const struct ov2722_reg ov2722_1M3_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x24},
>  	{OV2722_8BIT, 0x373a, 0x60},
> @@ -877,7 +877,7 @@ static struct ov2722_reg const ov2722_1M3_30fps[] = {
>  };
>  #endif
>  
> -static struct ov2722_reg const ov2722_1080p_30fps[] = {
> +static const struct ov2722_reg ov2722_1080p_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for a whole
>  					frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -983,7 +983,7 @@ static struct ov2722_reg const ov2722_1080p_30fps[] = {
>  };
>  
>  #if 0 /* Currently unused */
> -static struct ov2722_reg const ov2722_720p_30fps[] = {
> +static const struct ov2722_reg ov2722_720p_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03},
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x24},