linux-kernel - Re: [PATCH] serial: core: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bd769b7f66bca4e97dba57276f5a29acdabb655.camel@tektelic.com>
Date: Tue, 8 Jul 2025 13:37:45 +0000
From: Aidan Stewart <astewart@...telic.com>
To: Johan Hovold <johan@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>
CC: Jiri Slaby <jirislaby@...nel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: core: fix OF node leak

Hi Johan,

On Tue, 2025-07-08 at 10:58 +0200, Johan Hovold wrote:
> 
> 
> CAUTION: This email originated from outside the organization. Do not
> click links or open attachments unless you recognize the sender and know
> the content is safe.
> 
> 
> 
> Make sure to drop the OF node reference taken when initialising the
> control and port devices when the devices are later released.
> 
> Fixes: d36f0e9a0002 ("serial: core: restore of_node information in
> sysfs")
> Cc: Aidan Stewart <astewart@...telic.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/tty/serial/serial_base_bus.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/serial_base_bus.c
> b/drivers/tty/serial/serial_base_bus.c
> index cb3b127b06b6..22749ab0428a 100644
> --- a/drivers/tty/serial/serial_base_bus.c
> +++ b/drivers/tty/serial/serial_base_bus.c
> @@ -13,6 +13,7 @@
>  #include <linux/device.h>
>  #include <linux/idr.h>
>  #include <linux/module.h>
> +#include <linux/of.h>
>  #include <linux/serial_core.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> @@ -93,6 +94,7 @@ static void serial_base_ctrl_release(struct device
> *dev)
>  {
>         struct serial_ctrl_device *ctrl_dev =
> to_serial_base_ctrl_device(dev);
> 
> +       of_node_put(dev->of_node);
>         kfree(ctrl_dev);
>  }
> 
> @@ -140,6 +142,7 @@ static void serial_base_port_release(struct device
> *dev)
>  {
>         struct serial_port_device *port_dev =
> to_serial_base_port_device(dev);
> 
> +       of_node_put(dev->of_node);
>         kfree(port_dev);
>  }
> 
> --
> 2.49.0
Thanks for the fix. I think this also needs to go into -stable, as the
previous changes have already landed there (6.12.36 and 6.15.5).

Aidan