linux-kernel - Re: [PATCH] serial: core: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG03-g3gVMgErPIA@hovoldconsulting.com>
Date: Tue, 8 Jul 2025 17:23:38 +0200
From: Johan Hovold <johan@...nel.org>
To: Aidan Stewart <astewart@...telic.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: core: fix OF node leak

On Tue, Jul 08, 2025 at 01:37:45PM +0000, Aidan Stewart wrote:
> On Tue, 2025-07-08 at 10:58 +0200, Johan Hovold wrote:

> > Make sure to drop the OF node reference taken when initialising the
> > control and port devices when the devices are later released.
> > 
> > Fixes: d36f0e9a0002 ("serial: core: restore of_node information in
> > sysfs")
> > Cc: Aidan Stewart <astewart@...telic.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>

> Thanks for the fix. I think this also needs to go into -stable, as the
> previous changes have already landed there (6.12.36 and 6.15.5).

I left out the stable tag on purpose since this leak should not cause
trouble as, for example, these devices are typically registered at boot
and never deregistered.

It fixes an issue introduced in rc4 so it should preferably still go
into 6.16-final, though.

Johan