linux-kernel - Re: [PATCH] serial: core: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025070801-jelly-lyrically-0f65@gregkh>
Date: Tue, 8 Jul 2025 17:26:10 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Johan Hovold <johan@...nel.org>
Cc: Aidan Stewart <astewart@...telic.com>,
	Jiri Slaby <jirislaby@...nel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: core: fix OF node leak

On Tue, Jul 08, 2025 at 05:23:38PM +0200, Johan Hovold wrote:
> On Tue, Jul 08, 2025 at 01:37:45PM +0000, Aidan Stewart wrote:
> > On Tue, 2025-07-08 at 10:58 +0200, Johan Hovold wrote:
> 
> > > Make sure to drop the OF node reference taken when initialising the
> > > control and port devices when the devices are later released.
> > > 
> > > Fixes: d36f0e9a0002 ("serial: core: restore of_node information in
> > > sysfs")
> > > Cc: Aidan Stewart <astewart@...telic.com>
> > > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> > Thanks for the fix. I think this also needs to go into -stable, as the
> > previous changes have already landed there (6.12.36 and 6.15.5).
> 
> I left out the stable tag on purpose since this leak should not cause
> trouble as, for example, these devices are typically registered at boot
> and never deregistered.
> 
> It fixes an issue introduced in rc4 so it should preferably still go
> into 6.16-final, though.

Ok, will get this merged, thanks!

greg k-h