linux-kernel - [PATCH][next] mmc: loongson2: Fix comparison of unsigned integer with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708135348.1888817-1-colin.i.king@gmail.com>
Date: Tue,  8 Jul 2025 14:53:48 +0100
From: Colin Ian King <colin.i.king@...il.com>
To: Binbin Zhou <zhoubinbin@...ngson.cn>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Huacai Chen <chenhuacai@...nel.org>,
	linux-mmc@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][next] mmc: loongson2: Fix comparison of unsigned integer with less than zero

From: Colin Ian King <colin.i.king@...el.com>

Currently the u32 variable ret is being assigned the return value from
the call to regmap_read_poll_timeout and checking for a less than zero
error return and this check is always false. Fix this by making ret a
signed integer.

Fixes: d0f8e961deae ("mmc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
Signed-off-by: Colin Ian King <colin.i.king@...el.com>
---
 drivers/mmc/host/loongson2-mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
index 515ccf834f0a..ba6bb8fd5535 100644
--- a/drivers/mmc/host/loongson2-mmc.c
+++ b/drivers/mmc/host/loongson2-mmc.c
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
 
 static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
 {
-	u32 val, pad_delay, delay, ret;
+	u32 val, pad_delay, delay;
+	int ret;
 
 	regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
 			   LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);
-- 
2.50.0