linux-kernel - Re: [PATCH][next] mmc: loongson2: Fix comparison of unsigned integer with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <104dd784-29bb-445e-8581-b5d1e1d22a8f@loongson.cn>
Date: Wed, 9 Jul 2025 09:34:50 +0800
From: Binbin Zhou <zhoubinbin@...ngson.cn>
To: Colin Ian King <colin.i.king@...il.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Huacai Chen <chenhuacai@...nel.org>,
 linux-mmc@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] mmc: loongson2: Fix comparison of unsigned integer
 with less than zero

Hi Colin:

Thanks for your patch.

Sergio has already submitted the relevant patch to fix this issue:

https://lore.kernel.org/all/20250707185545.46275-1-sperezglz@gmail.com/

Thank you for your attention to loongson2 mmc driver.

在 2025/7/8 21:53, Colin Ian King 写道:
> From: Colin Ian King <colin.i.king@...el.com>
>
> Currently the u32 variable ret is being assigned the return value from
> the call to regmap_read_poll_timeout and checking for a less than zero
> error return and this check is always false. Fix this by making ret a
> signed integer.
>
> Fixes: d0f8e961deae ("mmc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
> Signed-off-by: Colin Ian King <colin.i.king@...el.com>
> ---
>   drivers/mmc/host/loongson2-mmc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index 515ccf834f0a..ba6bb8fd5535 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
>   
>   static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
>   {
> -	u32 val, pad_delay, delay, ret;
> +	u32 val, pad_delay, delay;
> +	int ret;
>   
>   	regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
>   			   LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);
Thanks.
Binbin