linux-kernel - Re: [PATCH] media: i2c: Kconfig: Select COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <04c7c949-d0ac-43c0-91cb-7445cb44a036@app.fastmail.com>
Date: Tue, 08 Jul 2025 18:28:12 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Mehdi Djait" <mehdi.djait@...ux.intel.com>,
 "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
 "laurent.pinchart" <laurent.pinchart@...asonboard.com>
Cc: "Jacopo Mondi" <jacopo.mondi@...asonboard.com>,
 "Hans Verkuil" <hverkuil@...all.nl>,
 "Kieran Bingham" <kieran.bingham@...asonboard.com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Hans de Goede" <hdegoede@...hat.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: Kconfig: Select COMMON_CLK for ACPI-based systems

On Tue, Jul 8, 2025, at 18:16, Mehdi Djait wrote:
> ACPI-based systems are required to create and register a fixed rate clock
> using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
> common clk framework.
>
> Ensure that COMMON_CLK is selected.
>
> Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>

You should never 'select' another subsystem or a drvier from
an unrelated subsystem.

What you want here instead is 'depends on COMMON_CLK'.

      Arnd