linux-kernel - Re: [PATCH] media: i2c: Kconfig: Select COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72ujdqoreqdvzkuenq7y67yvr67ncjisr5nqvlgxqkihmjfqcq@fxedxajs2zwu>
Date: Wed, 9 Jul 2025 09:48:46 +0200
From: Mehdi Djait <mehdi.djait@...ux.intel.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	"laurent.pinchart" <laurent.pinchart@...asonboard.com>, Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	Hans Verkuil <hverkuil@...all.nl>, Kieran Bingham <kieran.bingham@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans de Goede <hdegoede@...hat.com>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: Kconfig: Select COMMON_CLK for ACPI-based
 systems

Hello Arnd,

Thank you for the review.

On Tue, Jul 08, 2025 at 06:28:12PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 8, 2025, at 18:16, Mehdi Djait wrote:
> > ACPI-based systems are required to create and register a fixed rate clock
> > using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
> > common clk framework.
> >
> > Ensure that COMMON_CLK is selected.
> >
> > Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>
> 
> You should never 'select' another subsystem or a drvier from
> an unrelated subsystem.
> 
> What you want here instead is 'depends on COMMON_CLK'.

Ack.

I will change this in the v2.

--
Kind Regards
Mehdi Djait