lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250708172617.GA652174-robh@kernel.org>
Date: Tue, 8 Jul 2025 12:26:17 -0500
From: Rob Herring <robh@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-wireless@...r.kernel.org,
	Toke Høiland-Jørgensen <toke@...e.dk>,
	nbd@....name, jeff.johnson@....qualcomm.com,
	Johannes Berg <johannes@...solutions.net>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: net: wireless: ath9k: add led bindings

On Fri, Jul 04, 2025 at 02:42:17PM -0700, Rosen Penev wrote:
> This is used to override the various defaults the ath9k driver has for
> LED pin values.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  .../bindings/net/wireless/qca,ath9k.yaml         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> index d16ca8e0a25d..58c7b873cecb 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> @@ -50,6 +50,19 @@ properties:
>  
>    ieee80211-freq-limit: true
>  
> +  led:
> +    type: object
> +    $ref: /schemas/leds/common.yaml#
> +    additionalProperties: false

You really don't want any other common properties? Like defining the 
function?

> +    properties:
> +      led-active-low:
> +        description:
> +          LED is enabled with ground signal.
> +        type: boolean
> +
> +      led-sources:
> +        maxItems: 1

This property is really for cases where the LED source is configurable 
from the LED instance. If that's not the case here just use 'reg' for 
each instance (assuming there's more than 1). I shouldn't be wondering 
what the h/w looks like though. Please describe it in the commit msg 
rather than what some driver does.

If you do need led-sources, you should define some constraints on the 
values, not just the length.

Rob


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ