linux-kernel - Re: [PATCH v6 06/30] x86/resctrl: Move L3 initialization out of domain_add_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2af48f47-1b6e-4d7a-a5fc-7a37d57fbeb1@intel.com>
Date: Tue, 8 Jul 2025 13:56:44 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v6 06/30] x86/resctrl: Move L3 initialization out of
 domain_add_cpu_mon()

Hi Tony,

I do not think the subject is accurate since this patch does not
actually move L3 initialization out of domain_add_cpu_mon().
L3 initialization is still done in domain_add_cpu_mon() but
instead of being open coded it is done in function called
by domain_add_cpu_mon(). Perhaps something like:
"x86/resctrl: Move L3 initialization into function"?


On 6/26/25 9:49 AM, Tony Luck wrote:
> To prepare for additional types of monitoring domains, move all the L3
> resource monitoring domain initialization out of domain_add_cpu_mon()
> and into a new helper function l3_mon_domain_setup() (name chosen
> as the partner of existing l3_mon_domain_free()).

Similar comment as with subject. Also please note that l3_mon_domain_free()
does not exist at this point in the series. How about something like below,
(please feel free to improve):

	To prepare for additional types of monitoring domains, move open coded
	L3 resource monitoring domain initialization from domain_add_cpu_mon()             
	into a new helper function l3_mon_domain_setup() called by                      
	domain_add_cpu_mon().

> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Patch looks good to me.

Reinette