linux-kernel - Re: [PATCH] efi: Drop preprocessor directives from zboot.lds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9b407a5-d83a-4aa2-8cbc-15077f47c797@redhat.com>
Date: Mon, 7 Jul 2025 20:46:44 -0400
From: Luiz Capitulino <luizcap@...hat.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Vitaly Kuznetsov <vkuznets@...hat.com>, linux-efi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi: Drop preprocessor directives from zboot.lds

On 2025-07-07 19:51, Ard Biesheuvel wrote:
> On Tue, 8 Jul 2025 at 07:36, Luiz Capitulino <luizcap@...hat.com> wrote:
>>
>> On 2025-06-06 11:55, Luiz Capitulino wrote:
>>> On 2025-06-06 11:41, Vitaly Kuznetsov wrote:
>>>> Older versions of `ld` don't seem to support preprocessor directives in
>>>> linker scripts, e.g. on RHEL9's ld-2.35.2-63.el9 the build fails with:
>>>>
>>>>    ld:./drivers/firmware/efi/libstub/zboot.lds:32: ignoring invalid character `#' in expression
>>>>    ld:./drivers/firmware/efi/libstub/zboot.lds:33: syntax error
>>>>
>>>> We don't seem to need these '#ifdef', no empty .sbat section is created
>>>> when CONFIG_EFI_SBAT_FILE="":
>>>>
>>>>    # objdump -h arch/arm64/boot/vmlinuz.efi
>>>>
>>>>    arch/arm64/boot/vmlinuz.efi:     file format pei-aarch64-little
>>>>
>>>>    Sections:
>>>>    Idx Name          Size      VMA               LMA               File off  Algn
>>>>      0 .text         00b94000  0000000000001000  0000000000001000  00001000  2**2
>>>>                      CONTENTS, ALLOC, LOAD, READONLY, CODE
>>>>      1 .data         00000200  0000000000b95000  0000000000b95000  00b95000  2**2
>>>>                      CONTENTS, ALLOC, LOAD, DATA
>>>>
>>>> Fixes: 0f9a1739dd0e ("efi: zboot specific mechanism for embedding SBAT section")
>>>> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>>>
>>> Thanks for fixing Vitaly:
>>>
>>> Tested-by: Luiz Capitulino <luizcap@...hat.com>
>>>
>>> (this is for the build test, not SBAT testing).
>>
>> Vitaly, Ard,
>>
>> Are we planning to include this fix for 6.16? I'm afraid we'll introduce a
>> regression if we don't include it.
>>
> 
> Apologies, I let this sit for a bit longer than I intended. I'll send
> out the PR today.

Thanks a lot, Ard!