linux-kernel - Re: [PATCH] driver core: auxiliary bus: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708095908.GE592765@unreal>
Date: Tue, 8 Jul 2025 12:59:08 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dave Ertman <david.m.ertman@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Jerome Brunet <jbrunet@...libre.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: fix OF node leak

On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when creating an auxiliary
> device using auxiliary_device_create() when the device is later
> released.

I'm probably missing something, but random grep for the
device_set_of_node_from_dev() callers shows that none of them are
calling to of_node_put() explicitly.

Thanks

> 
> Fixes: eaa0d30216c1 ("driver core: auxiliary bus: add device creation helpers")
> Cc: Jerome Brunet <jbrunet@...libre.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/base/auxiliary.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index dba7c8e13a53..6bdefebf3609 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -399,6 +399,7 @@ static void auxiliary_device_release(struct device *dev)
>  {
>  	struct auxiliary_device *auxdev = to_auxiliary_dev(dev);
>  
> +	of_node_put(dev->of_node);
>  	kfree(auxdev);
>  }
>  
> @@ -435,6 +436,7 @@ struct auxiliary_device *auxiliary_device_create(struct device *dev,
>  
>  	ret = auxiliary_device_init(auxdev);
>  	if (ret) {
> +		of_node_put(auxdev->dev.of_node);
>  		kfree(auxdev);
>  		return NULL;
>  	}
> -- 
> 2.49.0
>