linux-kernel - Re: [PATCH] driver core: auxiliary bus: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGztOnNKu3gvFH2_@hovoldconsulting.com>
Date: Tue, 8 Jul 2025 12:04:42 +0200
From: Johan Hovold <johan@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dave Ertman <david.m.ertman@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Jerome Brunet <jbrunet@...libre.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: fix OF node leak

On Tue, Jul 08, 2025 at 12:59:08PM +0300, Leon Romanovsky wrote:
> On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
> > Make sure to drop the OF node reference taken when creating an auxiliary
> > device using auxiliary_device_create() when the device is later
> > released.
> 
> I'm probably missing something, but random grep for the
> device_set_of_node_from_dev() callers shows that none of them are
> calling to of_node_put() explicitly.

Yeah, the platform bus code takes care of dropping the reference for
platform devices.

Johan